Fix #17797 -- Realsig+ generates nested closures with incorrect Generic arguments #17877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
KevinRansom
force-pushed
the
fix17797
branch
4 times, most recently
from
35a8aad to
a7eeda8
Compare
KevinRansom
force-pushed
the
fix17797
branch
5 times, most recently
from
bb06ffa to
1d562ef
Compare
KevinRansom
force-pushed
the
fix17797
branch
8 times, most recently
from
e13abad to
ef80877
Compare
KevinRansom
changed the title
KevinRansom
force-pushed
the
fix17797
branch
from
376285d to
d2ff439
Compare
T-Gro
reviewed
Nov 26, 2024
tests/FSharp.Compiler.ComponentTests/EmittedIL/RealInternalSignature/ClassTypeInitialization.fs
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Nov 26, 2024
tests/FSharp.Compiler.ComponentTests/EmittedIL/RealInternalSignature/ClassTypeInitialization.fs
Show resolved
Hide resolved
T-Gro
reviewed
Nov 26, 2024
...ler.ComponentTests/EmittedIL/Inlining/Match01_RealInternalSignatureOn.fs.il.net472.debug.bsl
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Nov 26, 2024
...ler.ComponentTests/EmittedIL/Inlining/Match01_RealInternalSignatureOn.fs.il.net472.debug.bsl
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Nov 26, 2024
T-Gro
reviewed
Nov 26, 2024
tests/FSharp.Compiler.ComponentTests/Conformance/LexicalAnalysis/SymbolicOperators.fs
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Nov 26, 2024
tests/FSharp.Compiler.ComponentTests/EmittedIL/ComputedCollections/ComputedCollections.fs
Outdated
Show resolved
Hide resolved
|
My review is finished, but let's wait for the ilverify for realsig as a CI step as well. |
…is/SymbolicOperators.fs Yeah the comments are pointless. Co-authored-by: Tomas Grosup <[email protected]>
KevinRansom
commented
Dec 12, 2024
tests/FSharp.Compiler.ComponentTests/EmittedIL/RealInternalSignature/ClassTypeInitialization.fs
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/EmittedIL/RealInternalSignature/ClassTypeInitialization.fs
Outdated
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/EmittedIL/ComputedCollections/ComputedCollections.fs
Outdated
Show resolved
Hide resolved
T-Gro
approved these changes
Dec 13, 2024
psfinaki
approved these changes
Dec 19, 2024
Co-authored-by: Petr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When realsig+ is specified we generate closures as nested classes rather than classes at the same level as the class that the closures are for. This eliminates the need for members of the class to be internal allowing us to make the members private to reflect their source visibility.
Issue 17797 occurs because the closures were generated without the generic parameters. This fix addresses that by getting the generic parameters from the argument/typar environment.